Skip to content

fix: reject a lone minus in hex_to_decimal - #15714

Open
kevin9327 wants to merge 1 commit into
TheAlgorithms:masterfrom
kevin9327:fix/hex-to-decimal-lone-minus
Open

kevin9327 wants to merge 1 commit into
TheAlgorithms:masterfrom
kevin9327:fix/hex-to-decimal-lone-minus

Conversation

@kevin9327

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

hex_to_decimal("-") returned 0. After the leading minus is stripped, the remaining string is empty, and all([]) is True, so the function treated a lone minus as a valid value of zero. oct_to_decimal("-") already raises ValueError for the same input.

The new doctest only covers this rejected input. Existing examples are unchanged.

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

A string that is only "-" stripped to an empty payload, and all([]) is
True, so hex_to_decimal("-") returned 0. oct_to_decimal already rejects
that input as non-octal; treat a lone minus as non-hexadecimal too.
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant