Repository navigation
Conversation
A string that is only "-" stripped to an empty payload, and all([]) is
True, so hex_to_decimal("-") returned 0. oct_to_decimal already rejects
that input as non-octal; treat a lone minus as non-hexadecimal too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
hex_to_decimal("-")returned0. After the leading minus is stripped, the remaining string is empty, andall([])isTrue, so the function treated a lone minus as a valid value of zero.oct_to_decimal("-")already raisesValueErrorfor the same input.The new doctest only covers this rejected input. Existing examples are unchanged.
Checklist