fix(binary_search): return first occurrence when duplicates exist#14683
Closed
MD-Mushfiqur123 wants to merge 2 commits into
Closed
fix(binary_search): return first occurrence when duplicates exist#14683MD-Mushfiqur123 wants to merge 2 commits into
MD-Mushfiqur123 wants to merge 2 commits into
Conversation
Closing this pull request as invalid@MD-Mushfiqur123, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
binary_searchfunction encounters a sorted list with duplicate values, it returns the first match found during the search (which depends on the midpoint calculation), rather than the first occurrence of the target value.Fix
Instead of returning immediately when a match is found, continue searching to the left to find the first occurrence. The function now tracks the result with a
resultvariable and continues narrowing the search window to the left after finding a match.Testing
binary_search([1, 2, 2, 2, 3], 2)returns1binary_search([1, 1, 1, 2, 3], 1)returns0Fixes #13840