fix(split): support multi-character separators#14682
Closed
MD-Mushfiqur123 wants to merge 1 commit into
Closed
Conversation
Closing this pull request as invalid@MD-Mushfiqur123, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The custom
splitfunction instrings/split.pycompares each character in the input string against the full separator string, which means multi-character separators such as"--"are never matched and the string is returned unsplit.Root Cause
The function iterates over individual characters with
for index, char in enumerate(string): if char == separator:, which only works for single-character separators.Fix
Replace character-by-character iteration with substring matching at each position, comparing
string[index:index + separator_length]against the separator. This correctly handles separators of any length.Testing
"--"and"##"Fixes #14649