Skip to content

Simplify capitalize implementation - #14654

Open
Miladkhoshdel wants to merge 3 commits into
TheAlgorithms:masterfrom
Miladkhoshdel:simplify_capitalize_implementation
Open

Miladkhoshdel wants to merge 3 commits into
TheAlgorithms:masterfrom
Miladkhoshdel:simplify_capitalize_implementation

Conversation

@Miladkhoshdel

Copy link
Copy Markdown
Contributor

Describe your change:

Simplifies the capitalize implementation by using slicing to uppercase only the first character while preserving the rest of the string.

This keeps the existing behavior for strings, including empty strings and strings that start with non-letter characters. The previous implementation also implicitly handled None, but the function parameter is typed as str, so None is outside the declared input contract.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

dependabot Bot and others added 2 commits May 7, 2026 17:27
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 7, 2026
@Miladkhoshdel

Copy link
Copy Markdown
Contributor Author

Hi maintainers! Just following up on this PR since it has been open for a while and has received approvals. Is there anything else needed from my side to help move it forward?

Thanks!

@jordandunmire97-ai jordandunmire97-ai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will prosper to learning and moreover becoming more analytical with performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants