Conversation
priya-sundaram-dev
left a comment
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks @toonyyy — the Wilder-smoothing RSI, type hints and doctest are all good. A couple of minor fixes:
- Typo in the first docstring line:
"stciks prices"->"stock prices". - The function returns
len(price_changes)values (one per price change), so the output is offset by one fromstock_prices. A one-line note in the docstring clarifying the alignment (the first non-Nonevalue corresponds to the(window_size + 1)-th price) would save readers some head-scratching. - Consider adding
if __name__ == "__main__": import doctest; doctest.testmod()alongside the demo so the doctest runs locally, matching the repo convention.
Numerically it looks correct — nice work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Implemented the Relative Strength Index (RSI) algorithm, which analyses an array of stock prices to indicate whether a stock is overbought or oversold.
Checklist: