Add adjacency representation generator for closed Hamiltonian tours - #13645
Open
Naman-Vasudev wants to merge 5 commits into
Open
Naman-Vasudev wants to merge 5 commits into
Naman-Vasudev wants to merge 5 commits into
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
tests are failing
priya-sundaram-dev
left a comment
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Naman-Vasudev — clear docstring, type hints and doctests, and the closed-tour wrap-around logic reads well.
One robustness suggestion: next_city_map.get(city, "-") silently yields "-" when a node in nodes never appears in path. Since a valid tour should visit every node, I'd validate set(path) == set(nodes) up front and raise a ValueError on mismatch, so malformed input fails loudly instead of producing a "-" placeholder.
This pairs with your #13647 (ordinal representation) — both are TSP tour encodings used in GA crossover. It might read more cohesively if the two docstrings cross-reference each other (or live together), so a reader sees them as a family of representations.
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new algorithm that converts a path (permutation form) of a closed Hamiltonian tour into an adjacency representation vector.
Each position in the resulting vector corresponds to a city (in fixed alphabetical order), and the value at that position denotes the next city in the tour.