Enhancement: Adding missing return type to pi_estimator function#13427
Merged
MaximSmolskiy merged 2 commits intoTheAlgorithms:masterfrom Oct 17, 2025
Merged
Enhancement: Adding missing return type to pi_estimator function#13427MaximSmolskiy merged 2 commits intoTheAlgorithms:masterfrom
MaximSmolskiy merged 2 commits intoTheAlgorithms:masterfrom
Conversation
- Add -> None return type annotation to pi_estimator function - Improves code clarity and follows Python type hinting best practices - Function already had proper type hints for parameters
mindaugl
approved these changes
Oct 11, 2025
Contributor
Author
|
Hi, it would be great if I could get the ETA of the workflow approval. Thanks |
MaximSmolskiy
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
The code works perfectly however it does not give an output in return. The addition to the return type gives more clarity and adheres Python type hinting best practices
Checklist: