Added Skeletonizing and Pruning Operations - DIP - #13141
Conversation
…thub.com/joydipb01/Python into pruning_morph_op_hacktoberfest_joydipb01
…thub.com/joydipb01/Python into pruning_morph_op_hacktoberfest_joydipb01
for more information, see https://pre-commit.ci
…thub.com/joydipb01/Python into pruning_morph_op_hacktoberfest_joydipb01
algorithms-keeper
Bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| return (gray > 127) & (gray <= 255) | ||
|
|
||
|
|
||
| def neighbours(image: np.ndarray, x: int, y: int) -> list: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| return neighbour_points | ||
|
|
||
|
|
||
| def is_endpoint(image: np.ndarray, x: int, y: int) -> bool: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
| return (gray > 127) & (gray <= 255) | ||
|
|
||
|
|
||
| def neighbours(image: np.ndarray, x: int, y: int) -> list: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: x
Please provide descriptive name for the parameter: y
algorithms-keeper
Bot
removed
the
require descriptive names
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
Skeletonize + prune are real DIP algorithms, but: (1) commits a binary asset skeleton_lena.png; (2) pil_img.save("result_pruned.png") writes a file into CWD at module scope — should be guarded under if name == "main"; (3) edits the auto-generated DIRECTORY.md; (4) no doctests. Please make those four fixes.
Also, who holds the copyright on the image?
algorithms-keeper
Bot
added
awaiting changes
2 participants
Describe your change:
Added algorithm to prune a skeletonized image. In the process, added algorithm to skeletonize an image
Checklist: