Conversation
manuelaidos123
left a comment
There was a problem hiding this comment.
Tryt to Simplify the boundary checks for r_start and r_end, by adding additional checks to prevent IndexError, and replacing print statements with a logging mechanism, and configured logging for better debugging.
Contributor
Author
|
@manuelaidos123 Simplified boundary checks in Knuth's optimization for Optimal BST. Replaced the explicit fallback logic with direct min/max operations to ensure valid array bounds. |
manuelaidos123
approved these changes
Oct 18, 2024
manuelaidos123
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
The changes address potential issues with small intervals and overlapping boundaries in the current implementation of Knuth's optimization of Optimal BST algorithm.
find_optimal_binary_search_treefunctionFixes #11724
Checklist: