Adds Longest Arithmetic Subsequence (Review Reqd) - #11712
Open
tejaswi0910 wants to merge 19 commits into
Open
tejaswi0910 wants to merge 19 commits into
tejaswi0910 wants to merge 19 commits into
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto longArthSub
for more information, see https://pre-commit.ci
Author
I am working on it currently, no its not closed |
tejaswi0910
marked this pull request as ready for review
October 3, 2024 18:15
imSanko
suggested changes
Oct 4, 2024
imSanko
left a comment
Contributor
There was a problem hiding this comment.
Can we add some more tests?
…nto longArthSub
for more information, see https://pre-commit.ci
Author
|
hey @tianyizheng02, can you please review this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Summary:
This PR adds an implementation of the Longest Arithmetic Subsequence algorithm in Python. The function computes the length of the longest arithmetic subsequence from an input list of integers.
Key Features:
Implements the function longest_arithmetic_subsequence(nums: List[int]) -> int which:
Returns the length of the longest arithmetic subsequence.
Handles edge cases like empty arrays and None input.
Changes:
Added a function to calculate the longest arithmetic subsequence, supporting dynamic programming.
Added type hints using List from the typing module for clarity and static type checking.
The algorithm returns the length of the longest subsequence while ensuring:
For an empty array, the result is 0.
For a None array, a ValueError is raised.
Checklist: