Skip to content

Removed incorrect type hints#11711

Merged
tianyizheng02 merged 1 commit intoTheAlgorithms:masterfrom
MSaiAswin:master
Oct 4, 2024
Merged

Removed incorrect type hints#11711
tianyizheng02 merged 1 commit intoTheAlgorithms:masterfrom
MSaiAswin:master

Conversation

@MSaiAswin
Copy link
Contributor

@MSaiAswin MSaiAswin commented Oct 3, 2024

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Fixes #11701

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

tianyizheng02
tianyizheng02 requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are good and address the linked issue, but could you also add unit tests to these functions as well?

All algorithm files should have unit tests anyway, and not having tests is why we didn't catch the errors in this file for so long. If you can, we'd appreciate it if you could help us remedy this issue in case there are any other errors in this file.

@MSaiAswin
Copy link
Contributor Author

MSaiAswin commented Oct 4, 2024

Sure. Will do that

@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Oct 4, 2024

Actually, it looks like another contributor has added doctests in a different PR: #11721

I can approve your PR without unit tests as well as their PR with unit tests. That way, this file gets unit tests and both of you get to have a PR approved.

tianyizheng02
tianyizheng02 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests, but this will be covered by #11721 (see previous comment)

@tianyizheng02 tianyizheng02 merged commit 917ad62 into TheAlgorithms:master Oct 4, 2024
@tianyizheng02 tianyizheng02 mentioned this pull request Oct 4, 2024
Merged
15 tasks
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect format code 'c' used for string in min_cost_string_conversion.py

2 participants

@MSaiAswin @tianyizheng02