finding different diffraction parameters - #11608
Skywalkr-dev wants to merge 12 commits into
Conversation
algorithms-keeper
Bot
added
awaiting reviews
1c45213 to
9f4f139
Compare
algorithms-keeper
Bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,90 @@ | |||
| import math | |||
|
|
|||
| def check_min_intensity(slit_width = 1,diff_angle=0, wavelength=100): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: check_min_intensity. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: slit_width
Please provide type hint for the parameter: diff_angle
Please provide type hint for the parameter: wavelength
| r_val = (n_val-math.floor(n_val)==0) | ||
| return r_val | ||
|
|
||
| def check_max_intensity(slit_width=1,diff_angle=0,wavelength=100): |
There was a problem hiding this comment.
Please provide return type hint for the function: check_max_intensity. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: slit_width
Please provide type hint for the parameter: diff_angle
Please provide type hint for the parameter: wavelength
| r_val = (n_val-math.floor(n_val)==0) | ||
| return r_val | ||
|
|
||
| def intensity_single_slit(slit_width=1,diff_angle=0,wavelength=100): |
There was a problem hiding this comment.
Please provide return type hint for the function: intensity_single_slit. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: slit_width
Please provide type hint for the parameter: diff_angle
Please provide type hint for the parameter: wavelength
| i_coeff = (math.sin(beta)/beta)**2 | ||
| return f"{i_coeff} I0" | ||
|
|
||
| def intensity_double_slit(path_diff=0,intensity_max="I0"): |
There was a problem hiding this comment.
Please provide return type hint for the function: intensity_double_slit. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: path_diff
Please provide type hint for the parameter: intensity_max
c841c11 to
0f22124
Compare
algorithms-keeper
Bot
added
tests are failing
0875cfa to
6be6606
Compare
algorithms-keeper
Bot
added
tests are failing
5af688f to
80e4aaa
Compare
algorithms-keeper
Bot
added
tests are failing
03d8c2f to
ed575a4
Compare
1fcc192 to
9468055
Compare
bd2babe to
f3fbc60
Compare
for more information, see https://pre-commit.ci
067fd5f to
2119668
Compare
2119668 to
b1dd25f
Compare
2 participants
Describe your change:
**diffraction.py is a module used to calculate various parameters of single slit and double slit diffraction patterns such as
>>> checking if a given wavelength ,diffraction angle and slit width corresponds to the minimum intensity observed in the diffraction pattern.
>>> checking if a given wavelength ,diffraction angle and slit width corresponds to the minimum intensity observed in the diffraction pattern
>>> calculating the intensity of a fringe observed in a single slit diffraction pattern based on the slit width ,diffraction angle and wavelength.
>>> calculating the intensity of a fringe observed in a double slit diffraction pattern based on the path difference and the central maximum or the maximum intensity observed,
**
Checklist: