Skip to content

implementation of sorted vector machines#1156

Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom
anand-371:master
Aug 28, 2019
Merged

implementation of sorted vector machines#1156
cclauss merged 5 commits intoTheAlgorithms:masterfrom
anand-371:master

Conversation

@anand-371
Copy link
Copy Markdown
Contributor

for issue #840
I would like to add the Support Vector Machine algorithm implemented in Python 3.6.7
Requirements:
- sklearn

for issue #840 
I would like to add the Support Vector Machine algorithm implemented in Python 3.6.7
Requirements:
      - sklearn
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Aug 27, 2019

sklearn is already available in our Travis CI test runs:
https://github.com/TheAlgorithms/Python/blob/master/requirements.txt#L11

Please doctests that are detected by our Travis CI / pytest automated testing.
https://docs.python.org/3/library/doctest.html

Extra credit: https://docs.python.org/3/library/typing.html

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Aug 27, 2019

No machine learning tests yet. https://travis-ci.org/TheAlgorithms/Python/builds/577468985#L633

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Aug 27, 2019

sorted_vector_machines.py seems a bit more user friendly than svm.py.

Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss cclauss merged commit 2f8516e into TheAlgorithms:master Aug 28, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* svm.py

for issue TheAlgorithms#840 
I would like to add the Support Vector Machine algorithm implemented in Python 3.6.7
Requirements:
      - sklearn

* update svm.py

* update svm.py

* Update and renamed to sorted_vector_machines.py

* Updated sorted_vector_machines.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants