Skip to content

Enable ruff PGH003 rule - #11345

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:enable-ruff-PGH003-rule
Apr 2, 2024
Merged

Enable ruff PGH003 rule#11345
cclauss merged 6 commits into
TheAlgorithms:masterfrom
MaximSmolskiy:enable-ruff-PGH003-rule

Conversation

@MaximSmolskiy

@MaximSmolskiy MaximSmolskiy commented Apr 2, 2024

Copy link
Copy Markdown
Member

Describe your change:

Enable ruff PGH003 rule

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@MaximSmolskiy
MaximSmolskiy requested a review from cclauss as a code owner April 2, 2024 17:23
@cclauss

cclauss commented Apr 2, 2024

Copy link
Copy Markdown
Member

https://results.pre-commit.ci/run/github/63476337/1712078589.UpD0AFSfSeC62DLbaSMGKw

@cclauss
cclauss marked this pull request as draft April 2, 2024 17:28
@MaximSmolskiy
MaximSmolskiy marked this pull request as ready for review April 2, 2024 17:54
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Apr 2, 2024
This was referenced Apr 2, 2024
Closed
Closed
@cclauss

cclauss commented Apr 2, 2024

Copy link
Copy Markdown
Member

Please resolved git conflicts.

@MaximSmolskiy

MaximSmolskiy commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Please resolved git conflicts.

Done

@cclauss
cclauss enabled auto-merge (squash) April 2, 2024 19:29
@cclauss
cclauss merged commit 53b2926 into TheAlgorithms:master Apr 2, 2024
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2024
@MaximSmolskiy
MaximSmolskiy deleted the enable-ruff-PGH003-rule branch April 2, 2024 19:31
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaximSmolskiy @cclauss