Skip to content

Updated topological sort doctest - #10787

Closed
aryandgandhi wants to merge 1 commit into
TheAlgorithms:masterfrom
aryandgandhi:d_branch
Closed

Updated topological sort doctest#10787
aryandgandhi wants to merge 1 commit into
TheAlgorithms:masterfrom
aryandgandhi:d_branch

Conversation

@aryandgandhi

@aryandgandhi aryandgandhi commented Oct 22, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@aryandgandhi

aryandgandhi commented Oct 22, 2023

Copy link
Copy Markdown
Contributor Author

Hey @cclauss added doctests to topological sort, let me know if any changes need to be made, if not please add the Hacktoberfest tag, thanks!

This was referenced Oct 22, 2023
Closed
Closed
@cclauss cclauss changed the title Updated topological sort doctest closes #9943 Updated topological sort doctest Oct 22, 2023
cclauss
cclauss requested changes Oct 22, 2023
View reviewed changes

@cclauss cclauss left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding tests and changing the code is not allowed in a single pull request. Please do one or the other but not both.

@algorithms-keeper algorithms-keeper Bot added the awaiting changes A maintainer has requested changes to this PR label Oct 22, 2023
@cclauss cclauss self-assigned this Oct 22, 2023
@cclauss cclauss closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss requested changes

Assignees

@cclauss cclauss

Labels

awaiting changes A maintainer has requested changes to this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aryandgandhi @cclauss