Skip to content

Test cases for all_permutations - #10662

Open
RaymondDashWu wants to merge 10 commits into
TheAlgorithms:masterfrom
RaymondDashWu:all_permutations_tests
Open

Test cases for all_permutations#10662
RaymondDashWu wants to merge 10 commits into
TheAlgorithms:masterfrom
RaymondDashWu:all_permutations_tests

Conversation

@RaymondDashWu

@RaymondDashWu RaymondDashWu commented Oct 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Contributes to #9943. Minor fix with generate_all_permutations function printing instead of returning an output

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Add test cases

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 18, 2023
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 18, 2023
@RaymondDashWu
RaymondDashWu marked this pull request as draft October 18, 2023 05:01
@RaymondDashWu RaymondDashWu changed the title Test cases for all_permutations [WIP] Test cases for all_permutations Oct 18, 2023
@RaymondDashWu

RaymondDashWu commented Oct 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Converted to draft and will work on fixing algo because generate_all_permutations has a weird output

generate_all_permutations([1, 2])
Expected:
    [[1, 2], [2, 1]]
Got:
    [1, 2]
    [2, 1]

@RaymondDashWu RaymondDashWu changed the title [WIP] Test cases for all_permutations Test cases for all_permutations Oct 18, 2023
@RaymondDashWu
RaymondDashWu marked this pull request as ready for review October 18, 2023 06:36
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 18, 2023
@cclauss cclauss mentioned this pull request Sep 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RaymondDashWu