Added matrix exponentiation approach for finding fibonacci number. by mahbubcseju · Pull Request #1042 · TheAlgorithms/Python

mahbubcseju · 2019-07-19T04:38:36Z

Implemented matrix exponentiation for finding nth fibonnaci.
Complexity is about O(nlog(n)*8), here 8 is for matrix multiplication of size 2 by 2.

matrix/nth_fibonnacci_using_matrix_exponentiation.py

* Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8)

cclauss

Nice work. Thanks for your contribution.

In the filename and in the code, "Fibonacci" is sometimes spelled with two n. Please fix this so that it is properly spelled in all places.

matrix/nth_fibonnacci_using_matrix_exponentiation.py

- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request

cclauss · 2019-07-19T06:16:49Z

from timeit import timeit
print(timeit("nth_fibonacci(1000)", "from __main__ import nth_fibonacci", number=10000))
print(timeit("nth_fibonacci_test(1000)", "from __main__ import nth_fibonacci_test", number=10000))

1.565457206
1.273862879

mahbubcseju · 2019-07-19T06:27:48Z

from timeit import timeit
print(timeit("nth_fibonacci(1000)", "from __main__ import nth_fibonacci", number=10000))
print(timeit("nth_fibonacci_test(1000)", "from __main__ import nth_fibonacci_test", number=10000))

1.565457206
1.273862879

Yes . If the input is high like n=100000, you will get the difference.

mahbubcseju · 2019-07-19T06:36:24Z

from timeit import timeit
print(timeit("nth_fibonacci(1000)", "from __main__ import nth_fibonacci", number=10000))
print(timeit("nth_fibonacci_test(1000)", "from __main__ import nth_fibonacci_test", number=10000))

1.565457206
1.273862879

from timeit import timeit
print(timeit("nth_fibonacci(1000000)", "from main import nth_fibonacci", number=5))
print(timeit("nth_fibonacci_test(1000000)", "from main import nth_fibonacci_test", number=5))
2.3342058970001744
57.256506615000035

matrix/nth_fibonacci_using_matrix_exponentiation.py

cclauss · 2019-07-19T06:58:10Z

Perhaps the functions should be renamed to clarify intent:

nth_fibonacci() --> nth_fibonacci_matrix()
nth_fibonacci__test() --> nth_fibonacci_bruteforce()

mahbubcseju · 2019-07-19T07:05:59Z

nth_fibonacci_bruteforce

Changed

- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request

cclauss

Awesome work here!!

As a thank you for the nice work on TheAlgorithms/Python#1042... These test will run on each update to the code. You will need to log into https://travis-ci.org/mahbubcseju using your github credentials to turn on this free service. This is a simple config (but it still catches one issue on Python 3). To see a more complex config, see https://github.com/TheAlgorithms/Python/blob/master/.travis.yml

…mber. (#1042)" This reverts commit 60c608d.

…heAlgorithms#1042) * Added matrix exponentiation approach for finding fibonacci number. * Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8) * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Tighten up main() and add comments on performance Signed-off-by: Deus-Absconditus <cnidus9@zohomail.com>

…heAlgorithms#1042) * Added matrix exponentiation approach for finding fibonacci number. * Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8) * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Tighten up main() and add comments on performance

cclauss reviewed Jul 19, 2019

View reviewed changes

matrix/nth_fibonnacci_using_matrix_exponentiation.py Outdated Show resolved Hide resolved

Added matrix exponentiation approach for finding fibonacci number.

2a513f0

* Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8)

mahbubcseju force-pushed the master branch from 23131c4 to 2a513f0 Compare July 19, 2019 04:55

cclauss requested changes Jul 19, 2019

View reviewed changes

Updated the matrix exponentiation approach of finding nth fibonacci.

b159705

- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request

mahbubcseju force-pushed the master branch from 385a3ed to d417c84 Compare July 19, 2019 06:16

cclauss requested changes Jul 19, 2019

View reviewed changes

matrix/nth_fibonacci_using_matrix_exponentiation.py Outdated Show resolved Hide resolved

matrix/nth_fibonacci_using_matrix_exponentiation.py Outdated Show resolved Hide resolved

mahbubcseju force-pushed the master branch from d417c84 to 23a5333 Compare July 19, 2019 06:56

mahbubcseju force-pushed the master branch 3 times, most recently from 24df2cd to d30bbc1 Compare July 19, 2019 07:05

Updated the matrix exponentiation approach of finding nth fibonacci.

044cca8

- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request

mahbubcseju force-pushed the master branch from d30bbc1 to 044cca8 Compare July 19, 2019 07:09

Tighten up main() and add comments on performance

8e5481d

cclauss approved these changes Jul 19, 2019

View reviewed changes

cclauss merged commit 60c608d into TheAlgorithms:master Jul 19, 2019

cclauss mentioned this pull request Jul 19, 2019

Add free automated testing with Travis CI mahbubcseju/DroneFlight#1

Merged

cclauss added a commit that referenced this pull request Jul 19, 2019

Revert "Added matrix exponentiation approach for finding fibonacci nu…

2a8245c

…mber. (#1042)" This reverts commit 60c608d.

cclauss mentioned this pull request Jul 19, 2019

Revert "Added matrix exponentiation approach for finding fibonacci number." #1043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added matrix exponentiation approach for finding fibonacci number.#1042

Added matrix exponentiation approach for finding fibonacci number.#1042
cclauss merged 4 commits intoTheAlgorithms:masterfrom
mahbubcseju:master

mahbubcseju commented Jul 19, 2019

Uh oh!

Uh oh!

cclauss left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cclauss commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

Uh oh!

Uh oh!

cclauss commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

cclauss left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mahbubcseju commented Jul 19, 2019

Uh oh!

Uh oh!

cclauss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cclauss commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

Uh oh!

Uh oh!

cclauss commented Jul 19, 2019

Uh oh!

mahbubcseju commented Jul 19, 2019

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cclauss left a comment •

edited

Loading