add tests for enigma_machine - #10017
Open
gabriellypinto wants to merge 3 commits into
Open
Conversation
algorithms-keeper
Bot
added
enhancement
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
tests are failing
tianyizheng02
requested changes
Oct 22, 2023
| return code, token | ||
|
|
||
|
|
||
| def menu(): |
Contributor
There was a problem hiding this comment.
This code chunk is all driver code, so it's fine to keep it in the __main__ block.
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| def encode_or_decode(message, token): |
Contributor
There was a problem hiding this comment.
Isn't this just the body of the driver code? Why is it not used in the driver code?
Also, please add type hints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Related to #9943
Checklist: