Skip to content

Adding Binary Search Tree Program which was missing.#504

Closed
vsnehi wants to merge 2 commits intoTheAlgorithms:masterfrom
vsnehi:master
Closed

Adding Binary Search Tree Program which was missing.#504
vsnehi wants to merge 2 commits intoTheAlgorithms:masterfrom
vsnehi:master

Conversation

@vsnehi
Copy link
Copy Markdown

@vsnehi vsnehi commented Oct 19, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

vsnehi added 2 commits October 20, 2020 05:21
@vsnehi
Binary Search Tree
f71c10c 
I am adding One More File, that is BST
@vsnehi
Rename index.js to BinarySearchTree.js
0bb6ca6 
Updating Binary Search Tree.
@itsvinayak itsvinayak added the code style issue Failing style checks label Oct 31, 2020
marsonya
marsonya requested changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@marsonya marsonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make sure your changes pass the Test. It seems like a standard issue.
Refer to COUNTRIBUTING.md for more details regarding standard.

You may use standard --fix FILE_NAME to automatically fix some or all issues.

marsonya
marsonya reviewed Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@marsonya marsonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be abandoned, but I'll ping one more time, because I think it's great work! @er-vikramsnehi , could you rebase this and fix the linting errors?

@raklaptudirm raklaptudirm mentioned this pull request May 30, 2021
Closed
@stale
Copy link
Copy Markdown

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Jun 2, 2021
@stale
Copy link
Copy Markdown

stale bot commented Jun 9, 2021

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsonya marsonya marsonya requested changes

Assignees

No one assigned

Labels

code style issue Failing style checks wontfix Will not be fixed or is a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vsnehi @marsonya @itsvinayak