Skip to content

WhileLoopFactorial: Optimize and add tests #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 7 commits into from
Apr 21, 2022
Merged

WhileLoopFactorial: Optimize and add tests #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5f866c
Optimised the factorial function.
merelymyself Apr 21, 2022
a6767ba
Create WhileLoopFactorial.test.js
merelymyself Apr 21, 2022
de12e18
result *= num
merelymyself Apr 21, 2022
acce146
Update WhileLoopFactorial.test.js
merelymyself Apr 21, 2022
985d0c5
testFactorial function
merelymyself Apr 21, 2022
2d40205
Space for formatting.
merelymyself Apr 21, 2022
1956597
should fix the formatting issues. I was having trouble with npx stand…
merelymyself Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions Maths/WhileLoopFactorial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
/*
author: Theepag
author: Theepag, optimised by merelymyself
*/
export const factorialize = (num) => {
// Step 1. variable result to store num
let result = num
// If num = 0 OR 1, the factorial will return 1
if (num === 0 || num === 1) { return 1 }
// Step 1. Handles cases where num is 0 or 1, by returning 1.
let result = 1
// Step 2. WHILE loop
while (num > 1) {
result *= num // or result = result * num;
num-- // decrement 1 at each iteration
result = result * num // or result = result * num;
}
// Step 3. Return the factorial
return result
Expand Down
12 changes: 12 additions & 0 deletions Maths/test/WhileLoopFactorial.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { factorialize } from '../WhileLoopFactorial'

function testFactorial (n, expected) {
test('Testing on ' + n + '!', () => {
expect(factorialize(n)).toBe(expected)
})
}

testFactorial(3, 6)
testFactorial(7, 5040)
testFactorial(0, 1)
testFactorial(12, 479001600)