Skip to content

FindLCM: Improve code readablility #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 3 commits into from
Apr 20, 2022
+4 −11
Merged

FindLCM: Improve code readablility #985

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7938db7
fix: improving code readability
CarlosZoft Apr 19, 2022
589d281
fix: exchange break to return lcm
CarlosZoft Apr 19, 2022
ad3b0e6
fix: fixing condition for improve readability
CarlosZoft Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions Maths/FindLcm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,14 @@ const findLcm = (num1, num2) => {
return 'Please enter whole numbers.'
}

let maxNum
let lcm
// Check to see whether num1 or num2 is larger.
if (num1 > num2) {
maxNum = num1
} else {
maxNum = num2
}
lcm = maxNum
// Get the larger number between the two
const maxNum = Math.max(num1, num2)
let lcm = maxNum

while (true) {
if (lcm % num1 === 0 && lcm % num2 === 0) break
if (lcm % num1 === 0 && lcm % num2 === 0) return lcm
lcm += maxNum
}
return lcm
}

export { findLcm }