FindLCM: Improve code readablility#985
Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom Apr 20, 2022
Merged
Conversation
appgurueu
requested changes
Apr 20, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
I like the return; there already is a similar PR (https://github.com/TheAlgorithms/Javascript/pull/951/files) concerning the Math.max instead of the if-else. Again, please revert the change that relies on JS truthiness and use explicit comparison against zero (=== 0) as it is more readable and less error-prone in general.
(Technically the condition could even be shortened further as !((lcm % num1) || (lcm % num2)) according to De Morgan's law, but that sure would be unreadable ;) )
appgurueu
added
feature
Member
Author
|
true, i will fix this |
Member
Author
|
Fixed it. But what you think, i remove math.max approached in another PR or not? |
appgurueu
approved these changes
Apr 20, 2022
raklaptudirm
approved these changes
Apr 20, 2022
raklaptudirm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to the JavaScript community
Describe your change:
Checklist: