Skip to content

Round-trip testing for Atbash cipher#958

Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
trasherdk:fix/atbash
Mar 28, 2022
Merged

Round-trip testing for Atbash cipher#958
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
trasherdk:fix/atbash

Conversation

@trasherdk
Copy link
Copy Markdown
Contributor

To test if the algorithm actually works, it should both encode and decode.

  • fix the test description

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

- fix the test description
@trasherdk trasherdk requested a review from raklaptudirm as a code owner March 28, 2022 02:50
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, looks like it is working.

@raklaptudirm raklaptudirm added feature Adds a new feature Reviewed labels Mar 28, 2022
@raklaptudirm raklaptudirm changed the title fix(atbash): make the test a round trip Round-trip testing for Atbash cipher Mar 28, 2022
@raklaptudirm raklaptudirm merged commit 1249dbe into TheAlgorithms:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants