Algorithm to calculate the Arithmetic Geometric Mean#897
Merged
Conversation
raklaptudirm
requested changes
Feb 21, 2022
raklaptudirm
left a comment
raklaptudirm
left a comment
Member
There was a problem hiding this comment.
Please add tests for the algorithm.
Contributor
Author
I committed the test script now, but the "build" stage says that none of the methods are functions. " |
raklaptudirm
requested changes
Feb 23, 2022
raklaptudirm
left a comment
raklaptudirm
left a comment
Member
There was a problem hiding this comment.
toBe should be outside expect. Please fix all the instances where you put it inside.
Contributor
Author
|
My bad, sorry. I didn't notice. I'll fix it now |
Contributor
Author
|
I'll fix the other bugs now |
raklaptudirm
changed the title
raklaptudirm
approved these changes
Feb 24, 2022
raklaptudirm
added
algorithm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an algorithm to compute/find the Arithmetic-Geometric Mean between 2 numbers
aandg. I thought it would be a good idea since it shows how to compute at full precision without anepsiloncomparison, and there's already an Arithmetic Mean so I added this for completeness.Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.