Skip to content

improve average#868

Closed
RuSaG0 wants to merge 2 commits intoTheAlgorithms:masterfrom
RuSaG0:average
Closed

improve average#868
RuSaG0 wants to merge 2 commits intoTheAlgorithms:masterfrom
RuSaG0:average

Conversation

@RuSaG0
Copy link
Copy Markdown
Contributor

@RuSaG0 RuSaG0 commented Dec 9, 2021 •
edited
Loading

Fix a bug(check divide by zero) and improve of calc (can work with generators and custom selectors)

RuSaG0 added 2 commits December 9, 2021 03:05
@RuSaG0
average fn
e7a84a7 
Improved: working with generators, erorr if length is 0, custom selector fn
@RuSaG0
average
32565ed
@RuSaG0 RuSaG0 requested a review from raklaptudirm as a code owner December 9, 2021 00:14
@RuSaG0 RuSaG0 changed the title Average improve average Dec 9, 2021
raklaptudirm
raklaptudirm reviewed Dec 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned, not need to support all iterables. A simple array length check should suffice.

@raklaptudirm raklaptudirm added the on hold Being discussed by the maintainers label Dec 11, 2021
@raklaptudirm
Copy link
Copy Markdown
Member

raklaptudirm commented Apr 2, 2022

@RuSaG0 As we discussed in #870, implement that method as a separate function.

@raklaptudirm raklaptudirm added feature Adds a new feature changes required This pull request needs changes algorithm Adds or improves an algorithm and removed on hold Being discussed by the maintainers labels Apr 2, 2022
@stale
Copy link
Copy Markdown

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Apr 16, 2022
@stale
Copy link
Copy Markdown

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Apr 30, 2022
@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Apr 30, 2022

@RuSaG0 As we discussed in #870, implement that method as a separate function.

I agree, this is not really an improvement over the current code. Please open a new PR if you plan on adding this; this one has merge conflicts anyways.

@appgurueu appgurueu closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm left review comments

Assignees

No one assigned

Labels

algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature stale Closed due to age wontfix Will not be fixed or is a feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RuSaG0 @raklaptudirm @appgurueu