Skip to content

Added Maximum product of 3 numbers in an array#789

Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
devcer:master
Oct 20, 2021
Merged

Added Maximum product of 3 numbers in an array#789
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
devcer:master

Conversation

@devcer
Copy link
Copy Markdown
Contributor

@devcer devcer commented Oct 14, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@devcer devcer requested a review from raklaptudirm as a code owner October 14, 2021 15:42
raklaptudirm
raklaptudirm requested changes Oct 15, 2021
View reviewed changes
@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 15, 2021
@devcer devcer requested a review from raklaptudirm October 16, 2021 15:44
raklaptudirm
raklaptudirm approved these changes Oct 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, I was out of station for the last few days.

@raklaptudirm raklaptudirm merged commit 358b199 into TheAlgorithms:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devcer @raklaptudirm