Create keyFinder.js#78
Conversation
Find and retrieve the encryption key automatically Note: This is a draft version, please help to modify, Thanks!
the-codingninja
left a comment
the-codingninja
left a comment
There was a problem hiding this comment.
Please make it js file instead of a file without extension
winsonrich
left a comment
winsonrich
left a comment
There was a problem hiding this comment.
Please note that the file extension is renewed to js format, thank you.
|
This pull request introduces 1 alert when merging 5a75bca into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
optimized the indentation for the if statement in line 18
winsonrich
left a comment
winsonrich
left a comment
There was a problem hiding this comment.
optimize the indentation of if statement in line 18
|
This pull request introduces 1 alert when merging e0fa99b into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
some changes is made to optimize the function
|
This pull request introduces 1 alert when merging e41ad76 into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
winsonrich
left a comment
winsonrich
left a comment
There was a problem hiding this comment.
ES6 is used to fix such error
the-codingninja
left a comment
the-codingninja
left a comment
There was a problem hiding this comment.
There is still alert raised can you check it
Made 2 changes to optimize the match results: 1. use a loop to find the next digit of wordbank element and compare with outStr's digit 2. this part need to be optimize with the calculation of the number of occurance of word's probabilities
winsonrich
left a comment
winsonrich
left a comment
There was a problem hiding this comment.
Made 2 changes to optimize the match results:
- use a loop to find the next digit of wordbank element and compare with outStr's digit
- this part need to be optimize with the calculation of the number of occurance of word's probabilities
|
I would like you to see this article for usage of let and const instead of var https://medium.com/javascript-scene/javascript-es6-var-let-or-const-ba58b8dcde75 |
3 participants
Find and retrieve the encryption key automatically
Note: This is a draft version, please help to modify, Thanks!