Fix/742 migrate doctest for Vector2.js#752
Fix/742 migrate doctest for Vector2.js#752raklaptudirm merged 4 commits intoTheAlgorithms:masterfrom FabianKielmann:master
Conversation
|
Hey @FabianKielmann ! Don't worry, your contribution is very welcome! As a matter of fact, "my" take on migrating the Vector2 doctests basically looks the same 👍 So how 'bout this: I can add a few suggestions with some nitpicking here and you can take a look? If you want to see my version, it's right here. @raklaptudirm once all checks are fine, we should be good to merge this PR - and I will simply drop the commit regarding Vector2 from my PR. |
|
Oh crap, you already had a commit for it? Mea culpa! I probably should've asked how to tackle this in the issue before just doing something 😅 I really appreciate your suggestion and you still letting me make the PR. I'm working on it now and will add to this PR asap. |
…orted at the end of the file
|
Nah, all's good. The commit was on my machine only and not yet pushed when you submitted your PR. 👍 |
3 participants
I hope this is helping. I saw the issue and looked around how other people migrate and went ahead.
@defaude I hope this is not interfering with your work. I'm new to contributing to open source and I'm not too familiar with the workflows and rules. I just try to follow the contribution guidelines.
I'm also not too familiar with testing libraries and writing tests in general. So I hope this Pull Request will still help.
If there is any problem with it, please let me know and I'll try to fix it.
// edit: btw, I'm also here because of hacktoberfest