Feat: Added Memoize Func#732
Merged
pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom Oct 5, 2021
DmnChzl:feat/memoize-func
Merged
Feat: Added Memoize Func#732pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom DmnChzl:feat/memoize-func
pomkarnath98 merged 4 commits intoTheAlgorithms:masterfrom
DmnChzl:feat/memoize-func
Conversation
trasherdk
reviewed
Oct 5, 2021
Cache/Memoize.js
Outdated
| */ | ||
| export const memoize = (func) => { | ||
| // eslint-disable-next-line no-console | ||
| console.log(`Creating cache for function '${func.name}'`) |
Contributor
There was a problem hiding this comment.
Those console.log() are probably not crucial for the functionality, and don't look good when running tests.
Contributor
There was a problem hiding this comment.
While on the test subject. Where did you get the idea to name the directory __test__, when the rest is just test ?
Contributor
Author
There was a problem hiding this comment.
Oh! You're right. I apply my own convention rather than yours... My apologize 🙏
I'm gonna fix it!
raklaptudirm
requested changes
Oct 5, 2021
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
Please add some comments explaining what the algorithm does and how.
raklaptudirm
approved these changes
Oct 5, 2021
pomkarnath98
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again 👋
I added the memo algorithm inside the cache folder (unit tests included)
If that's okay for you, can you add the
hacktoberfest-acceptedmention? 🙏