Skip to content

Added test cases for LongestPalindromicSubsequence#721

Merged
pomkarnath98 merged 1 commit intoTheAlgorithms:masterfrom
pomkarnath98:master
Oct 3, 2021
Merged

Added test cases for LongestPalindromicSubsequence#721
pomkarnath98 merged 1 commit intoTheAlgorithms:masterfrom
pomkarnath98:master

Conversation

@pomkarnath98
Copy link
Copy Markdown
Member

@pomkarnath98 pomkarnath98 commented Oct 3, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98 pomkarnath98 merged commit fd42022 into TheAlgorithms:master Oct 3, 2021
Comment on lines +4 to +5
it('expects to return 0 as longest pallindromic subsequence', () => {
expect(longestPalindromeSubsequence('abcdefgh')).toBe(1)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expects to return 0 and toBe(1) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants