Skip to content

Added DecimalToRoman#707

Merged
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
beam41:master
Oct 2, 2021
Merged

Added DecimalToRoman#707
raklaptudirm merged 3 commits intoTheAlgorithms:masterfrom
beam41:master

Conversation

@beam41
Copy link
Copy Markdown

@beam41 beam41 commented Oct 1, 2021

Welcome to JavaScript community

Open in Gitpod know more

I find that repo has romanToDecimal but not decimalToRoman so I create one

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@beam41 beam41 requested a review from raklaptudirm October 2, 2021 10:39
@raklaptudirm raklaptudirm merged commit 56ccbfc into TheAlgorithms:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants