Skip to content

Dice#703

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
itsUrcute:dice
Oct 1, 2021
Merged

Dice#703
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
itsUrcute:dice

Conversation

@itsUrcute
Copy link
Copy Markdown
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Adds an algorithm to calculate Sørensen–Dice coefficient of 2 strings.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add some tests for the algorithm. See the test sub-directories for more info.

@itsUrcute itsUrcute requested a review from raklaptudirm October 1, 2021 05:49
@raklaptudirm
Copy link
Copy Markdown
Member

Please format your code with standard.js.

@raklaptudirm raklaptudirm merged commit 8c2f2ca into TheAlgorithms:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants