Added GetGCD and ReverseNumber method in Maths category.#670
Merged
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom Aug 31, 2021
suryapratapsinghsuryavanshi:master
Merged
Added GetGCD and ReverseNumber method in Maths category.#670raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom suryapratapsinghsuryavanshi:master
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
suryapratapsinghsuryavanshi:master
Conversation
raklaptudirm
requested changes
Aug 31, 2021
Member
raklaptudirm
left a comment
raklaptudirm
left a comment
There was a problem hiding this comment.
We already have a gcd implementation -> https://github.com/TheAlgorithms/Javascript/blob/master/Maths/FindHcf.js
Contributor
Author
|
But in this method, I have used a different approach to solving the GCD problem. |
Member
|
Then change the file name to something which describes the approach, or put it in the same file. |
raklaptudirm
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.