Skip to content

Added AlternativeStringArrange method in string category.#657

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
suryapratapsinghsuryavanshi:master
Aug 19, 2021
Merged

Added AlternativeStringArrange method in string category.#657
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
suryapratapsinghsuryavanshi:master

Conversation

@suryapratapsinghsuryavanshi
Copy link
Copy Markdown
Contributor

@suryapratapsinghsuryavanshi suryapratapsinghsuryavanshi commented Aug 18, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm requested changes Aug 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide some sources for the problem. For example:

/*
* https://en.wikipedia.org/binary%20search
*/

raklaptudirm
raklaptudirm requested changes Aug 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use standard.js to style the code. After installing the cli app, run standard --fix .. Fix any outstanding warnings.

@raklaptudirm raklaptudirm added the code style issue Failing style checks label Aug 18, 2021
@raklaptudirm raklaptudirm removed the code style issue Failing style checks label Aug 19, 2021
@raklaptudirm raklaptudirm merged commit 9cfc109 into TheAlgorithms:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suryapratapsinghsuryavanshi @raklaptudirm