Skip to content

Added the recursive-memoized approach for coin change combination pro…#650

Merged
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
mandy8055:coinChangeCombMem
Aug 15, 2021
Merged

Added the recursive-memoized approach for coin change combination pro…#650
raklaptudirm merged 6 commits intoTheAlgorithms:masterfrom
mandy8055:coinChangeCombMem

Conversation

@mandy8055
Copy link
Copy Markdown
Contributor

@mandy8055 mandy8055 commented Aug 11, 2021

…blem

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • [ v] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [v ] I have read CONTRIBUTING.md.
  • [ v] This pull request is all my own work -- I have not plagiarized.
  • [v ] I know that pull requests will not be merged if they fail the automated tests.
  • [v ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [v ] All new JavaScript files are placed inside an existing directory.
  • [v ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [ v] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [v ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm reviewed Aug 13, 2021
View reviewed changes
@mandy8055
Added 2 Base tests and 5 main tests for CoinChange Problem. Refactore…
fa15244 
…d the code and removed the Memoized approach as it was not necessary
@mandy8055
Copy link
Copy Markdown
Contributor Author

mandy8055 commented Aug 13, 2021 •
edited
Loading

Hi @raklaptudirm,
As you mentioned; I added 2 base tests and 5 main tests for CoinChange Problem. I Refactored the code a bit and removed the Memoized approach as it was not necessary or must do. There was one function named minimumCoins() which is another problem but is related to coinChangeCombination. I temporarily removed it. Once I'll be able to figure out the tests for the same, I'll add it too to the file.
Please do let me if it is okay for you.
Thanks

@mandy8055
Added 2 Base tests and 5 main tests for CoinChange Problem. Refactore…
43e9ebc 
…d the code and removed the Memoized approach as it was not necessary
@mandy8055
Added 2 Base tests and 5 main tests for CoinChange Problem. Refactore…
2ee9eb9 
…d the code and removed the Memoized approach as it was not necessary
@mandy8055
Added the tests for coinChangeMin function
9cf1e55
@raklaptudirm raklaptudirm merged commit 8051bfd into TheAlgorithms:master Aug 15, 2021
@mandy8055 mandy8055 deleted the coinChangeCombMem branch August 15, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandy8055 @raklaptudirm