Skip to content

Added the correct(stable) version of count sort. Changed function …#648

Merged
raklaptudirm merged 4 commits intoTheAlgorithms:masterfrom
mandy8055:countSortFix
Aug 8, 2021
Merged

Added the correct(stable) version of count sort. Changed function …#648
raklaptudirm merged 4 commits intoTheAlgorithms:masterfrom
mandy8055:countSortFix

Conversation

@mandy8055
Copy link
Copy Markdown
Contributor

@mandy8055 mandy8055 commented Aug 6, 2021

…declaration to ES6 style.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • [v ] Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [v ] I have read CONTRIBUTING.md.
  • [v ] This pull request is all my own work -- I have not plagiarized.
  • [v ] I know that pull requests will not be merged if they fail the automated tests.
  • [v ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ v] All new JavaScript files are placed inside an existing directory.
  • [v ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [v ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [v ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm requested changes Aug 8, 2021
View reviewed changes
mandy8055
mandy8055 commented Aug 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@mandy8055 mandy8055 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raklaptudirm,

Updated the frequency array creation and initialization. Removed the copying of result array to the original array portion. Please review and merge the PR.

Thanks

@mandy8055
Updated the count sort algorithm with stable implementation. Added ES…
6232f8d 
…6 syntactic sugar to the syntax
@mandy8055
Updated the count sort algorithm with stable implementation. Added ES…
faed847 
…6 syntactic sugar to the syntax. Removed the unwanted len variable and updated the comments
@raklaptudirm raklaptudirm merged commit b794143 into TheAlgorithms:master Aug 8, 2021
@mandy8055 mandy8055 deleted the countSortFix branch August 8, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mandy8055 @raklaptudirm