Skip to content

Added Volume.js into the Math file#640

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
leeyan44:master
Jul 20, 2021
Merged

Added Volume.js into the Math file#640
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
leeyan44:master

Conversation

@leeyan44
Copy link
Copy Markdown
Contributor

@leeyan44 leeyan44 commented Jul 19, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • [v] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [v] I have read CONTRIBUTING.md.
  • [v] This pull request is all my own work -- I have not plagiarized.
  • [v] I know that pull requests will not be merged if they fail the automated tests.
  • [v] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [v] All new JavaScript files are placed inside an existing directory.
  • [v] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [v] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [v] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

leeyan44 added 3 commits July 19, 2021 22:13
@leeyan44
create a Volume.js in the math file
3931903 
Volume.js in the math file is to calculate the volume of some shapes such as Cuboid, Cube, Cone, Pyramid, Cylinder, Triangular Prism, Pentagonal Prism, Sphere and Hemisphere.
@leeyan44
Update Volume.js
d7626e3
@leeyan44
Update Volume.js
9546f23
raklaptudirm
raklaptudirm requested changes Jul 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a Maths/test/Volume.test.js file for testing the algorithm. We use jest for testing. If you want to know how to write tests, refer to the other files in the test folder.

@leeyan44 @raklaptudirm
Update Maths/Volume.js
f52637f 
Co-authored-by: Rak Laptudirm <raklaptudirm@gmail.com>
@leeyan44 leeyan44 closed this Jul 20, 2021
@raklaptudirm
Copy link
Copy Markdown
Member

raklaptudirm commented Jul 20, 2021

@leeyan44 Why did you close the PR?

@leeyan44
Copy link
Copy Markdown
Contributor Author

leeyan44 commented Jul 20, 2021 via email

@raklaptudirm raklaptudirm reopened this Jul 20, 2021
@raklaptudirm
Copy link
Copy Markdown
Member

raklaptudirm commented Jul 20, 2021

@leeyan44 Thats ok. Now you see our repositories have a style guide to keep code consistent and readable. It seems like your code does not follow the style. You need to format your code with standard.js. Download the cli-app and run the command standard --fix . on the repository. If you need any help, ask me.

@raklaptudirm raklaptudirm merged commit 47a8c0e into TheAlgorithms:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leeyan44 @raklaptudirm