Skip to content

Added averageMedian function#636

Merged
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
qingwen23:find-average-median
Jul 19, 2021
Merged

Added averageMedian function#636
raklaptudirm merged 5 commits intoTheAlgorithms:masterfrom
qingwen23:find-average-median

Conversation

@qingwen23
Copy link
Copy Markdown

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files need to follow the format specified by standard.js. To format them, install the standard.js cli app and run standard --fix . in the repository. If it generates any warnings, fix them. This style allows our code to be readable and consistent.

@raklaptudirm raklaptudirm added the code style issue Failing style checks label Jul 19, 2021
@qingwen23 qingwen23 requested a review from raklaptudirm July 19, 2021 05:42
@raklaptudirm raklaptudirm merged commit 3716e56 into TheAlgorithms:master Jul 19, 2021
@raklaptudirm
Copy link
Copy Markdown
Member

@qingwen23 Thanks for contributing to the algorithms! We have repositories in many other languages as well if you are interested. You can also join our discord server. We are currently hosting a coding event there. Hope to see more contributions from you in the future!

@raklaptudirm raklaptudirm removed the code style issue Failing style checks label Jul 19, 2021
@qingwen23
Copy link
Copy Markdown
Author

@raklaptudirm Thanks! I would love to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants