Skip to content

fixed the merge implementation in MergeSort #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomkarnath98 merged 2 commits into from
May 22, 2021
Merged

fixed the merge implementation in MergeSort #599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1c6ea
fixed the merge implementation in MergeSort
guyariely May 5, 2021
2022a74
fixed mergeSort algorithm
guyariely May 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions Sorts/MergeSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,19 @@
*/

function merge (list1, list2) {
var results = []
const results = []
let i = 0
let j = 0

while (list1.length && list2.length) {
if (list1[0] <= list2[0]) {
results.push(list1.shift())
while (i < list1.length && j < list2.length) {
if (list1[i] < list2[j]) {
results.push(list1[i++])
} else {
results.push(list2.shift())
results.push(list2[j++])
}
}
return results.concat(list1, list2)

return results.concat(list1.slice(i), list2.slice(j))
}

/**
Expand All @@ -55,15 +58,15 @@ function merge (list1, list2) {
function mergeSort (list) {
if (list.length < 2) return list

var listHalf = Math.floor(list.length / 2)
var subList1 = list.slice(0, listHalf)
var subList2 = list.slice(listHalf, list.length)
const listHalf = Math.floor(list.length / 2)
const subList1 = list.slice(0, listHalf)
const subList2 = list.slice(listHalf, list.length)

return merge(mergeSort(subList1), mergeSort(subList2))
}

// Merge Sort Example
var unsortedArray = [10, 5, 3, 8, 2, 6, 4, 7, 9, 1]
var sortedArray = mergeSort(unsortedArray)
const unsortedArray = [10, 5, 3, 8, 2, 6, 4, 7, 9, 1]
const sortedArray = mergeSort(unsortedArray)

console.log('Before:', unsortedArray, 'After:', sortedArray)