Skip to content

Algorithm to print a month's calendar.#560

Merged
ruppysuppy merged 11 commits intoTheAlgorithms:masterfrom
raklaptudirm:master
Feb 7, 2021
Merged

Algorithm to print a month's calendar.#560
ruppysuppy merged 11 commits intoTheAlgorithms:masterfrom
raklaptudirm:master

Conversation

@raklaptudirm
Copy link
Copy Markdown
Member

@raklaptudirm raklaptudirm commented Jan 23, 2021 •
edited
Loading

This pull request adds an algorithm to Dynamic-programming which accepts a month in the format m/y, and prints the month's calendar.

Commits before 0f703a5 are unrelated and have been reverted back in 7c3b0ad.

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@raklaptudirm
Copy link
Copy Markdown
Member Author

raklaptudirm commented Jan 24, 2021

#14 Contribution. Added a new algorithm.

ruppysuppy
ruppysuppy requested changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the one liner conditionals into different lines. In isLeapYear else is not required, you can just use return false

@raklaptudirm
Copy link
Copy Markdown
Member Author

raklaptudirm commented Feb 6, 2021

Split the one liner conditionals into different lines. In isLeapYear else is not required, you can just use return false

Removed the else but breaking the conditional raises standard js formatting issues.

@ruppysuppy
chore: split conditionals
f7819ed 
Split block of conditionals in separate lines to improve readability
@ruppysuppy ruppysuppy merged commit eaed625 into TheAlgorithms:master Feb 7, 2021
@ruppysuppy
Copy link
Copy Markdown
Member

ruppysuppy commented Feb 7, 2021

@raklaptudirm from next time please open separate PRs for different tasks (you had squashed Kadane's algorithm improvement and the calendar together)

@raklaptudirm
Copy link
Copy Markdown
Member Author

raklaptudirm commented Feb 8, 2021 •
edited
Loading

@raklaptudirm from next time please open separate PRs for different tasks (you had squashed Kadane's algorithm improvement and the calendar together)

@ruppysuppy Actually, I ran standard --fix on the code so it automatically changed that, but sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruppysuppy ruppysuppy ruppysuppy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raklaptudirm @ruppysuppy