Skip to content

Doctest contribution Guidelines added to Contributing.md - #546

Merged
marsonya merged 4 commits into
TheAlgorithms:masterfrom
marsonya:doctest-contribution-guidelines
Dec 18, 2020
Merged

Doctest contribution Guidelines added to Contributing.md#546
marsonya merged 4 commits into
TheAlgorithms:masterfrom
marsonya:doctest-contribution-guidelines

Conversation

@marsonya

@marsonya marsonya commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

I have added Doctest contribution guidelines to Contributing.md.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • [x ] This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@marsonya marsonya mentioned this pull request Nov 2, 2020
@marsonya

marsonya commented Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Hey @itsvinayak, this PR is ready to be merged after your review. It's been open for a month. Kindly take a look.

@marsonya
marsonya merged commit f004692 into TheAlgorithms:master Dec 18, 2020
@marsonya
marsonya deleted the doctest-contribution-guidelines branch December 18, 2020 12:46
@marsonya
marsonya restored the doctest-contribution-guidelines branch January 12, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant