Skip to content

Improved CocktailShakerSort and added Doctests#545

Merged
marsonya merged 7 commits intoTheAlgorithms:masterfrom
marsonya:doctests/cocktail-shaker-sort
Dec 18, 2020
Merged

Improved CocktailShakerSort and added Doctests#545
marsonya merged 7 commits intoTheAlgorithms:masterfrom
marsonya:doctests/cocktail-shaker-sort

Conversation

@marsonya
Copy link
Copy Markdown
Contributor

@marsonya marsonya commented Nov 2, 2020

Here are the changes I made in the Sorts/CocktailShakerSort.js file:

  • Improved Comments and Formatting.
  • The function in CocktailShakerSort was not returning the array. Changed that.
  • Improved the Implementation Examples and Console logs.
  • And Finally, added doctests as mentioned in (Issue #142)
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@marsonya
Copy link
Copy Markdown
Contributor Author

marsonya commented Dec 4, 2020

Hey @itsvinayak, this PR is ready to be merged after your review. It's been open for a month. Kindly take a look.

@marsonya marsonya requested a review from cclauss December 16, 2020 12:52
@marsonya marsonya merged commit 1abd3aa into TheAlgorithms:master Dec 18, 2020
@marsonya marsonya deleted the doctests/cocktail-shaker-sort branch January 12, 2021 18:09
@marsonya marsonya restored the doctests/cocktail-shaker-sort branch January 12, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant