Skip to content

add binary convert#521

Merged
itsvinayak merged 9 commits intoTheAlgorithms:masterfrom
arwysyah:arwysyah
Oct 31, 2020
Merged

add binary convert#521
itsvinayak merged 9 commits intoTheAlgorithms:masterfrom
arwysyah:arwysyah

Conversation

@arwysyah
Copy link
Copy Markdown
Contributor

add convert number to binary number

@arwysyah
Copy link
Copy Markdown
Contributor Author

sorry i am just new coder, i made many mistakes about code especially on Test,but i try to fix it ,hope you can understand

@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented Oct 31, 2020

hey @arwysyah, sorry for responding so late, you did great work.
please add some documentation(comment and hints) for a better understanding of code and if possible please squash your commits.

looking forward to more PRs

thank you,
@itsvinayak

@itsvinayak itsvinayak added beginner-friendly Easy to implement changes required This pull request needs changes good first issue labels Oct 31, 2020
@arwysyah
Copy link
Copy Markdown
Contributor Author

Add documentation

@itsvinayak itsvinayak merged commit eab57b8 into TheAlgorithms:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner-friendly Easy to implement changes required This pull request needs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants