Skip to content

fixed issue with delete operator on stacks#218

Merged
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
harishsambasivam:master
Jul 24, 2020
Merged

fixed issue with delete operator on stacks#218
itsvinayak merged 3 commits intoTheAlgorithms:masterfrom
harishsambasivam:master

Conversation

@harishsambasivam
Copy link
Copy Markdown
Contributor

@harishsambasivam harishsambasivam commented Jul 1, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@harishsambasivam
fixed issue with delete operator
83cfdef 
using delete operator in arrays ,element remains undefined. so splice is the clean way to do that
@itsvinayak itsvinayak added the code style issue Failing style checks label Jul 2, 2020
@itsvinayak
Copy link
Copy Markdown
Member

itsvinayak commented Jul 2, 2020

@harishsambasivam thanks for the PR but some tests are falling link
please have a look, use npm standards as specified in the documentation, and mark X in the column of PR template
feel free to ask questions

thank you,
@itsvinayak

@harishsambasivam
Copy link
Copy Markdown
Contributor Author

harishsambasivam commented Jul 20, 2020

Fixed the issue with Delete operator

@itsvinayak itsvinayak merged commit 8a9ea57 into TheAlgorithms:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsvinayak itsvinayak itsvinayak approved these changes

Assignees

No one assigned

Labels

code style issue Failing style checks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harishsambasivam @itsvinayak