Skip to content

Added basic palindrome checking algorithm#216

Closed
ruppysuppy wants to merge 1 commit intoTheAlgorithms:masterfrom
ruppysuppy:palindrome
Closed

Added basic palindrome checking algorithm#216
ruppysuppy wants to merge 1 commit intoTheAlgorithms:masterfrom
ruppysuppy:palindrome

Conversation

@ruppysuppy
Copy link
Copy Markdown
Member

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@@ -0,0 +1,21 @@
// Wikipedia: https://en.wikipedia.org/wiki/Palindrome

function isPalindrome (string) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this algo already exists #213

Copy link
Copy Markdown
Member Author

@ruppysuppy ruppysuppy Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see it. I am closing the PR.

@ruppysuppy ruppysuppy closed this Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants