Added backtracking (sudoku)#205
Merged
itsvinayak merged 2 commits intoTheAlgorithms:masterfrom Jun 26, 2020
Merged
Conversation
ruppysuppy
commented
Jun 25, 2020
back-tracking/Sudoku.js
Outdated
Comment on lines
+55
to
+60
| for (let i = 0; i < 9; i++) { | ||
| if (i % 3 === 0 && i !== 0) console.log('- - - - - - - - - - - -') | ||
| const part1 = board[i].slice(0, 3) | ||
| const part2 = board[i].slice(3, 6) | ||
| const part3 = board[i].slice(6, 9) | ||
| console.log(...part1, ' | ', ...part2, ' | ', ...part3) |
Member
Author
There was a problem hiding this comment.
Is this acceptable or I should have directly used the sliced parts in the spread operation?
Member
There was a problem hiding this comment.
@ruppysuppy , here we are repeating code, what about creating a function that will take a board with indexes, and return part1
so we can do something like
console.log(Slice(board[i],0,3),' | ', .....)
itsvinayak
reviewed
Jun 25, 2020
Member
itsvinayak
left a comment
itsvinayak
left a comment
There was a problem hiding this comment.
as we are passing board everywhere, what about creating classes. we use ES6 which introduced classes.
it will be a good idea to use classes
class Sudoku {
constructor(board) {
this.board = board
}
}
itsvinayak
approved these changes
Jun 26, 2020
Member
itsvinayak
left a comment
itsvinayak
left a comment
There was a problem hiding this comment.
really looks good,
thank you @ruppysuppy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.