Skip to content

fix: reject non-binary input in BinaryToDecimal #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin9327 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reject non-binary input in BinaryToDecimal #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Conversions/BinaryToDecimal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
export default function binaryToDecimal(binaryString) {
if (typeof binaryString !== 'string') {
throw new TypeError('Argument is not a string type')
}

if (!/^[01]+$/.test(binaryString)) {
throw new Error('Argument is not a valid binary string!')
}

let decimalNumber = 0
const binaryDigits = binaryString.split('').reverse() // Splits the binary number into reversed single digits
binaryDigits.forEach((binaryDigit, index) => {
Expand Down
11 changes: 11 additions & 0 deletions Conversions/test/BinaryToDecimal.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,15 @@ describe('BinaryToDecimal', () => {
it('expects to return correct hexadecimal value for padding-required binary', () => {
expect(binaryToDecimal('1000101')).toBe(69)
})

it('expects to throw for a non-string argument', () => {
expect(() => binaryToDecimal(1000)).toThrowError()
expect(() => binaryToDecimal(null)).toThrowError()
})

it('expects to throw for a non-binary string', () => {
expect(() => binaryToDecimal('2')).toThrowError()
expect(() => binaryToDecimal('102')).toThrowError()
expect(() => binaryToDecimal('')).toThrowError()
})
})
Loading