Skip to content

fix: reject non-binary input in BinaryToDecimal - #2027

Open
kevin9327 wants to merge 1 commit into
TheAlgorithms:masterfrom
kevin9327:fix/binary-to-decimal-invalid-digits
Open

fix: reject non-binary input in BinaryToDecimal#2027
kevin9327 wants to merge 1 commit into
TheAlgorithms:masterfrom
kevin9327:fix/binary-to-decimal-invalid-digits

Conversation

@kevin9327

@kevin9327 kevin9327 commented Nov 12, 2026

Copy link
Copy Markdown

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

binaryToDecimal('2') currently returns 2, and binaryToDecimal('102') returns 6. Invalid digits are coerced into the place-value sum instead of being rejected.

This change rejects non-string arguments and any string that is not only 0 and 1, matching the validation already used in HexToBinary and HexToDecimal.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@kevin9327
fix: reject non-binary input in BinaryToDecimal
7153180 
Digits other than 0 and 1 were coerced into the place-value sum,
so binaryToDecimal('2') returned 2 and binaryToDecimal('102')
returned 6.
@kevin9327
kevin9327 requested a review from appgurueu as a code owner November 12, 2026 02:51
@codecov-commenter

codecov-commenter commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (5c39e87) to head (7153180).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   85.91%   85.92%           
=======================================
  Files         379      379           
  Lines       19778    19786    +8     
  Branches     3016     3018    +2     
=======================================
+ Hits        16993    17001    +8     
  Misses       2785     2785

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu Awaiting requested review from appgurueu appgurueu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevin9327 @codecov-commenter