Skip to content

Added max non adjacent sum#197

Merged
itsvinayak merged 1 commit intoTheAlgorithms:masterfrom
ruppysuppy:max-non-adj-sum
Jun 21, 2020
Merged

Added max non adjacent sum#197
itsvinayak merged 1 commit intoTheAlgorithms:masterfrom
ruppysuppy:max-non-adj-sum

Conversation

@ruppysuppy
Copy link
Copy Markdown
Member

@ruppysuppy ruppysuppy commented Jun 21, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ruppysuppy
Copy link
Copy Markdown
Member Author

ruppysuppy commented Jun 21, 2020

I am unable to rebase using git rebase HEAD~2 --onto master the commits due to some problem in HeapSort.js (I haven't touched it but it says that there are some changes, which I am unable to stage either using git add .)

itsvinayak
itsvinayak requested changes Jun 21, 2020
View reviewed changes
Web-Programming/OpenWeatherMaps.js Outdated
@@ -0,0 +1,31 @@
const fetch = require('node-fetch')
Copy link
Copy Markdown
Member

@itsvinayak itsvinayak Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is already in this #196 PR, please remove this file from this PR so, no conflict arises

Copy link
Copy Markdown
Member Author

@ruppysuppy ruppysuppy Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I branched off from the web-programming branch by mistake and due to the HeapSort issue I am unable to rebase the branch on the master. What should I do?

@itsvinayak itsvinayak merged commit b2b1ad3 into TheAlgorithms:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsvinayak itsvinayak itsvinayak requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruppysuppy @itsvinayak