Skip to content

Added Web-Programming (Open Weather Maps data fetch)#196

Merged
itsvinayak merged 2 commits intoTheAlgorithms:masterfrom
ruppysuppy:web-prog-owm
Jun 21, 2020
Merged

Added Web-Programming (Open Weather Maps data fetch)#196
itsvinayak merged 2 commits intoTheAlgorithms:masterfrom
ruppysuppy:web-prog-owm

Conversation

@ruppysuppy
Copy link
Copy Markdown
Member

@ruppysuppy ruppysuppy commented Jun 21, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • Fixes: Addition of Web Programming #187

@@ -0,0 +1,31 @@
const fetch = require('node-fetch')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this requirement,
we can add a common package.json file which can be used to install all requirements using
npm install

and please remove package-lock.json file
thank you @ruppysuppy

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please add a global package.json file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a global package.json file and removed package-lock.json but the HeapSort was causing some issues, I didn't touch it but it was modified by itself.

@itsvinayak itsvinayak mentioned this pull request Jun 21, 2020
11 tasks
@itsvinayak itsvinayak merged commit 412995a into TheAlgorithms:master Jun 21, 2020
@itsvinayak
Copy link
Copy Markdown
Member

nice work !!

@ruppysuppy
Copy link
Copy Markdown
Member Author

Thanks a lot for helping me out with the branch issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addition of Web Programming

2 participants